Patch for Mantis v2.25 & PHP8, resolves 8 open issues with this plugin #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects calls missing quotes
Uses correct method of accessing plugin file and removes click event cancellation js which isn't required. Unclear from issue but believe this also fixes mantisbt-plugins#16
Provided perhaps better separation and spacing from normal login button, fits with Googles style guidelines here: https://developers.google.com/identity/branding-guidelines
duncanbarnes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following issues are resolved with this change:
Believe that the below are also resolved but difficult to be sure as the issue descriptions are not clear enough: #16, #15
It also changes the login button for one that conforms with Googles requirements for using this authentication system. Branding guidelines available here: https://developers.google.com/identity/branding-guidelines
Tested on latest MantisBT v2.25